Add fields required for SSX to events route #250
Conversation
mgaonach
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 66.95% 67.02% +0.07%
==========================================
Files 109 109
Lines 5072 5083 +11
==========================================
+ Hits 3396 3407 +11
Misses 1676 1676
Continue to review full report at Codecov.
|
| @@ -47,6 +47,8 @@ class EntityType: | |||
| models.DataCollection.DataCollectionGroup, | |||
| models.DataCollectionGroup.Workflow, | |||
| ], | |||
| models.DataCollection.SSXDataCollection, | |||
There was a problem hiding this comment.
It'd be sensible to make this optional based on if models.DataCollection.SSXDataCollection exists. That way if people dont have the table it doesnt break the app
| @@ -155,6 +167,8 @@ class DataCollection(DataCollectionBase): | |||
|
|
|||
| DataCollectionGroup: DataCollectionGroup | |||
| GridInfo: Optional[list[GridInfo]] | |||
| SSXDataCollection: Optional[sqlalchemy_to_pydantic(models.SSXDataCollection)] | |||
There was a problem hiding this comment.
This is more complicated because its nested and not generated at run time. The easy option is to manually define the Schema in this case. Will have to think about runtime possibilities...
No description provided.